accounts/abi/bind: Accept function ptr parameter #19755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
force-pushed
the
abigen-function-callback
branch
from
b30f539 to
8d9db9b
Compare
They are translated as [24]byte
gballet
force-pushed
the
abigen-function-callback
branch
from
8d9db9b to
8f5785e
Compare
holiman
reviewed
Jun 28, 2019
| Code string `json:"code"` | ||
| RuntimeCode string `json:"runtime-code"` | ||
| Info ContractInfo `json:"info"` | ||
| Hashes map[string]string `json:"hashes"` |
Contributor
There was a problem hiding this comment.
Is there any need to keep this backwards compatible, or do we assume that ppl always regenerate stuff and there's no need to parse stuff which doesn't have hashes ?
Member
Author
There was a problem hiding this comment.
It is backwards-compatible in the sense that this is a convenience conversion table so that client code can quickly lookup a function name given its hash. Older client code that won't be regenerated will simply have to do the translation themselves.
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solidity now supports a
functionparameter type, which is a function pointer. At the bytecode level, this is a 24-byte digit with the first 20 bytes being the address of the contract and the last 4 being the 4 byte identifier of the function's signature.This PR enables the support for this
functiontype in Go, by replacing it with[24]byte. It also adds a helper map to easily convert from the 4-byte id to the function name.This is meant to address #17096